[TASK] Extend MathExpressionNode tests with chained math #398
Conversation
Adds test cases for expressions like {a + 1 * 2}.
|
This would actually have been rebased away since it got fixed in another PR ;) |
|
Hm, so I just wasted time coming up with nice labels? ;-) |
|
Not sure it's wasted, I went the way of more or less writing out the entire fluid expression for easier debugging: https://github.com/TYPO3/Fluid/pull/396/files#diff-273f993b0da6a2bc91976237ec4881b6R45 - not sure which one to prefer. The only argument I can give is you wouldn't need to look at the test data set to know the expression that failed (without turning words into mental code first). |
|
OK, that's true indeed. Notice that I would rewrite |
|
@mbrodala I think this is ready - trimmed down to only adding test cases for chained math. |
Pull Request Test Coverage Report for Build 1167
💛 - Coveralls |
| 'Invalid operator returns zero' => ['1 gabbagabbahey 1', [], 0], | ||
| 'Simple addition' => ['1 + 1', [], 2], | ||
| 'Chained addition' => ['1 + 1 + 1', [], 3], | ||
| 'Multiplication before addition' => ['1 + 1 * 2', [], 4], |
There was a problem hiding this comment.
Uhm, shouldn't this be 3?
There was a problem hiding this comment.
The expressions don't know about operator priority, so 1 + 1 = 2 * 2 = 4 is what it sees. It intentionally also doesn't know about parenthesis grouping in order to KISS.
If you know a reasonable way to implement operator priority (see also source of the expression class) I'd definitely consider adding that as a feature.
Adds test cases for expressions like {a + 1 * 2}.
Also labels test cases.